Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: wlr layer shell surface are guaranteed to have a nonzero size #3675

Closed
wants to merge 1 commit into from

Conversation

mattkae
Copy link
Contributor

@mattkae mattkae commented Nov 18, 2024

What's new?

  • Layer shell surfaces are guaranteed to have a requested size of 640x480 in the event that no size is found. This requests clients from making the mistake of allocating a zero-sized buffer
  • WindowWlSurfaceRole::current_size() now returns std::nullopt when it cannot reasonably resolve a size

To test

  • Install cosmic-bg
  • Run it
  • Note that you do not crash

@AlanGriffiths
Copy link
Collaborator

As discussed on chat, I think this is the wrong place for the fix: See #3676 for my alternative.

@mattkae
Copy link
Contributor Author

mattkae commented Nov 19, 2024

As discussed on chat, I think this is the wrong place for the fix: See #3676 for my alternative.

Unfortunately did not fix my particular issue

@mattkae
Copy link
Contributor Author

mattkae commented Nov 22, 2024

Closing in favor of #3676

@mattkae mattkae closed this Nov 22, 2024
@mattkae mattkae deleted the bugfix/initial_wl_layer_surface_size branch November 22, 2024 21:17
github-merge-queue bot pushed a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants